Move node-fetch types to dev dependencies#489
Closed
rowanu wants to merge 1 commit intomakenotion:mainfrom
Closed
Conversation
|
|
MohammedEsafi
approved these changes
Feb 9, 2024
Contributor
|
Nice, thanks! This is already included as part of #506 so I'll close this out, but let me know if there's anything remaining to dig into here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
@types/node-fetchis included independencieswhich is bloating production builds with types:notion-sdk-js/package.json
Line 43 in b66c67d
Types aren't used in production, so this makes no functional difference, this PR just moves it in to
devDependencieslike the other@types/...dependencies.