Additional fixes PersistenceBuilder handling of embedded docs#5
Merged
malarzm merged 6 commits intomalarzm:gh1141from Jun 13, 2015
Merged
Additional fixes PersistenceBuilder handling of embedded docs#5malarzm merged 6 commits intomalarzm:gh1141from
malarzm merged 6 commits intomalarzm:gh1141from
Conversation
See logic in UnitOfWork::persistNew().
Restructures the nullable handling and adds an early continue statement. Additionally, limit reference-one handling to owning sides, which is consistent with prepareUpdateData() and prepareUpsertData().
Remove a level of indentation for the embed-many branch by moving the $new check to the main conditional.
Embedded documents were never scheduled for upsert, so they would only be inserted at this point. The embed-many condition for prepareUpsertData() should be identical to what we already do in prepareInsertData(), so we can add an early continue statement and eliminate the later conditionals.
This addresses an earlier hypothesis that embedded documents are never scheduled for upsert (due to logic in UnitOfWork::persistNew()).
malarzm
added a commit
that referenced
this pull request
Jun 13, 2015
Additional fixes PersistenceBuilder handling of embedded docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: doctrine#1142