formats/all.cpp: Include IPF, 86F disk formats in floptool #13935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPF is included unconditionally by scripts/formats.lua, so the HAS_FORMATS condition was always false. 86F is also included unconditionally but simply wasn't added to formats/all.cpp when it was introduced. I added 86F to the "Container FM/MFM" category for consistency with the grouping in devices/imagedev/floppy.cpp and moved IPF to the "PC" category for the same reason.
|
While I was doing this, I ran some regexes and found other formats that are missing from all.cpp. However, I don't know much about these additional formats or have samples to test, so I left them out of this change. If anyone want to take that up, here is the missing code. #ifdef HAS_FORMATS_ABC1600_DSK
#include "abc1600_dsk.h"
#endif
#ifdef HAS_FORMATS_BK0010_DSK
#include "bk0010_dsk.h"
#endif
#ifdef HAS_FORMATS_IDPART_DSK
#include "idpart_dsk.h"
#endif
#ifdef HAS_FORMATS_LW30_DSK
#include "lw30_dsk.h"
#endif
#ifdef HAS_FORMATS_TIBDD001_DSK
#include "tibdd001_dsk.h"
#endif
#ifdef HAS_FORMATS_ABC1600_DSK
en.add(FLOPPY_ABC1600_FORMAT); // abc1600_dsk.h
#endif
#ifdef HAS_FORMATS_BK0010_DSK
en.add(FLOPPY_BK0010_FORMAT); // bk0010_dsk.h
#endif
#ifdef HAS_FORMATS_IDPART_DSK
en.add(FLOPPY_IDPART_FORMAT); // idpart_dsk.h
#endif
#ifdef HAS_FORMATS_LW30_DSK
en.add(FLOPPY_LW30_FORMAT); // lw30_dsk.h
#endif
#ifdef HAS_FORMATS_TIBDD001_DSK
en.add(FLOPPY_TIB_DD_001_FORMAT); // tibdd001_dsk.h
#endif
#ifdef HAS_FORMATS_CP68_DSK
en.add(FLOPPY_CP68_FORMAT); // cp68_dsk.h
#endif
#ifdef HAS_FORMATS_FDOS_DSK
en.add(FLOPPY_FDOS_FORMAT); // fdos_dsk.h
#endif
#ifdef HAS_FORMATS_MFM_HD
en.add(MFMHD_GEN_FORMAT); // mfm_hd.h
#endif
#ifdef HAS_FORMATS_ACORN_DSK
en.add(FLOPPY_CUMANA_DFS_FORMAT); // acorn_dsk.h
#endif |
|
Is it okay to have IPF and 86F enabled everywhere? @galibert |
|
IPF has a decent header, shouldn't be a problem. 86F I don't know, never
saw that format.
…On Thu, Jul 17, 2025 at 2:02 PM Angelo Salese ***@***.***> wrote:
*angelosa* left a comment (mamedev/mame#13935)
<#13935 (comment)>
Is it okay to have IPF and 86F enabled everywhere? @galibert
<https://github.com/galibert>
—
Reply to this email directly, view it on GitHub
<#13935 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGSF4KKL3EPGSWP42G4R633I6GFJAVCNFSM6AAAAACBGMRYH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBTG44TAMRZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
To be clear, this change doesn't enable these formats for any new devices. It adds two formats to mame_formats_full_list(), which is only utilized by floptool. It will affect the auto-detect feature of that tool, but both formats have unique header identifiers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPF is included unconditionally by scripts/formats.lua, so the HAS_FORMATS condition was always false.
86F is also included unconditionally but simply wasn't added to formats/all.cpp when it was introduced.
I added 86F to the "Container FM/MFM" category for consistency with the grouping in devices/imagedev/floppy.cpp and moved IPF to the "PC" category for the same reason.
cf. 3b13ae6, add6b45