sinclair/tsconf.cpp: Added FPGA 100K variant; implemented Copper for it. #14008
+358
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelosa
reviewed
Jul 30, 2025
Comment on lines
+107
to
+108
| return; | ||
| break; |
There was a problem hiding this comment.
Isn't return and break at same time going to throw a compiler error?
There was a problem hiding this comment.
Neither clang nor gcc failed the compilation. I was thinking having break everywhere is more consistent.
angelosa
reviewed
Jul 30, 2025
src/mame/sinclair/tsconf_copper.cpp
Outdated
| case 0b1110: // CALL | ||
| m_ret_pc = m_pc + 1; | ||
| m_pc = data & 0xff; | ||
| break; |
angelosa
reviewed
Jul 30, 2025
src/mame/sinclair/tsconf.h
Outdated
| @@ -173,6 +177,7 @@ class tsconf_state : public spectrum_128_state | |||
| void draw_sprites(screen_device &screen, bitmap_rgb32 &bitmap, const rectangle &cliprect); | |||
| void tsconf_update_video_mode(); | |||
| void copy_tiles_to_raw(const u8 *tiles_src, u8 *raw_target); | |||
| attotime cooper_until_pos_r(u16 pos); | |||
There was a problem hiding this comment.
This became Bob Cooper somehow 🎵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.