Skip to content

Conversation

holub
Copy link
Contributor

@holub holub commented Aug 30, 2025

No description provided.

@holub
Copy link
Contributor Author

holub commented Aug 30, 2025

I see couple places which need to be redone. Appreciate if somebody else participate in visual review as well.

@ICEknigh7
Copy link
Contributor

Sorry if there may be some duplicates reported above, I had submitted all these three hours ago but Github had them "Pending" for some reason.

@holub
Copy link
Contributor Author

holub commented Aug 31, 2025

Thanks @angelosa @ICEknigh7, your discovers must be ok now

@holub
Copy link
Contributor Author

holub commented Aug 31, 2025

Thought: maybe UI needs to group such items instead of producing long separated list
image

@etabeta78
Copy link
Contributor

etabeta78 commented Aug 31, 2025 via email

@holub
Copy link
Contributor Author

holub commented Aug 31, 2025

UI-friendliness was one of the reasons why these features were supposed to be unique :-) my 2c

On Sun, Aug 31, 2025 at 6:52 PM holub @.> wrote: holub left a comment (mamedev/mame#14101) <#14101 (comment)> Thought: maybe UI needs to group such items instead of producing long separated list image.png (view on web) https://github.com/user-attachments/assets/f7255c17-01b8-4c24-9234-28aa34bfa2e5 — Reply to this email directly, view it on GitHub <#14101 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGSVPF7AICJ63FVUZYMYAT3QMR5HAVCNFSM6AAAAACFHBSOA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBQGI3TCMBRGU . You are receiving this because you are subscribed to this thread.Message ID: @.>

By "unique" you mean opposite? Items which produces unpredictable amount of filter options... English + English/Spanish + ...
Plus confusing separation in case "&amp;" "," or "/" are part of developer name where you can't understand clearly if that's true separation or such authentic name.
Fixing UI is not a big deal when we have these items properly separated.

@holub
Copy link
Contributor Author

holub commented Sep 1, 2025

I fixed UI as well
image

@angelosa
Copy link
Member

angelosa commented Sep 1, 2025

I don't like this UI display, what's the point in splitting all the developers / languages if the end result is essentially equivalent to <info name="developer" value="AAAA / BBBB / CCCC / ..." />. At worst can cause confusion and give people the idea that's the way to go if they trust the UI more than actually checking for hash samples.

@holub
Copy link
Contributor Author

holub commented Sep 1, 2025

The value is in filter options.
Chanting the separatior to something uncomon e.g. will be more visually correct.

@angelosa
Copy link
Member

angelosa commented Sep 1, 2025

Sounds like a stall, let's hear back @cuavas opinion.

@angelosa angelosa requested a review from cuavas September 1, 2025 10:59
@ICEknigh7
Copy link
Contributor

For context, this is how the UI display looks in the latest public release (MAME 0.280):
image

@cuavas
Copy link
Member

cuavas commented Sep 1, 2025

Let’s get the metadata cleanup in now and worry about the UI later.

@cuavas cuavas merged commit f1fc482 into mamedev:master Sep 1, 2025
7 of 8 checks passed
@holub holub deleted the softlist-tags branch September 1, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants