Fix debugger's memdump command. #14257
Merged
+108
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holub
reviewed
Oct 2, 2025
cuavas
reviewed
Oct 13, 2025
Comment on lines
+116
to
+118
| while((handle == m_dispatch_array[i][k]) && (k < BITMASK)) { | ||
| k++; | ||
| } |
There was a problem hiding this comment.
Is this even safe? It looks like it has the potential to read off the end of a single-element array. The same thing happens further down. These sorts of “decrement counter after the loop” things are fertile ground for bugs.
@galibert have you looked at this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memdump will now properly report overlapping views.