-
Notifications
You must be signed in to change notification settings - Fork 2.3k
sd1 (21 voice) BIOS 4.xx now correctly detects speed. #14591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9062e29 to
0b43402
Compare
|
I see nothing in that patch that would make a difference in whatever method the bios uses to detect speed. |
|
It's the previous patch to esq5505.cpp that makes the detection code in the 4.xx BIOSes work. Now that the detection works, this patch simply makes those BIOS ROMs and their matching Sequencer OS floppy disks available on the sd1 (21-voice) as well. |
|
I'm not a fan of rug-pulling an entire software list after one version. That's one of the reasons I suggested using the compatibility tag initially. Changes are obviously necessary sometimes, but I don't think we've ever added a list and then deleted it in the next version, which is what's being proposed here. |
|
Would you prefer if I restored the |
|
That's an alternative, if SD-32 has compatibility with void esq5505_state::sd132(machine_config &config, int panel_type)
[...]
SOFTWARE_LIST(config, "sd132_flop").set_original("sd132_flop");
SOFTWARE_LIST(config.replace(), "sd1_flop").set_compatible("sd1_flop"); |
This allows the 4.xx BIOS to correctly configure the emulated sd1 for 21 voices and thus play at the correct pitch. Thus the SD-1 Sequencer OS 4.xx floppies now also apply to the SD-1. So this also consolidates the `sd1_flop` and `sd132_flop` software lists into a single `sd1_flop` list - but still keeps the `vfxsd_flop` list separate because that is still sufficiently different. The consolidated `sd1_flop` software list uses `<sharedfeat name="compatibility" ... />` to allow the different sd1 versions to show only those floppies that apply, respectively: The sd132 does not show the Sequencer OS 3.00 floppy; the sd1 does not show the demo disks. Arguably this is not quite right because all the demos would at least technically work even on the 21-voice SD-1, in particular those for other keyboards (SQ and KS series) which only use the SD-1's sequencer; but any SD-1/32 demos would run out of voices and thus sound worse than they should if played on an SD-1 (21-voice), so it seems a safer bet to make those only available on the SD-1/32.
disks. Sequencer OS disks are now all in the sd1_flop list.
0b43402 to
9b77546
Compare
|
Restored the |
This allows the 4.xx BIOS to correctly configure the emulated sd1 for 21 voices and thus play at the correct pitch.
Thus the SD-1 Sequencer OS 4.xx floppies now also apply to the SD-1.
So this also consolidates the
sd1_flopandsd132_flopsoftware lists into a singlesd1_floplist - but still keeps thevfxsd_floplist separate because that is still sufficiently different.The consolidated
sd1_flopsoftware list uses<sharedfeat name="compatibility" ... />to allow the different sd1 versions to show only those floppies that apply, respectively: The sd132 does not show the Sequencer OS 3.00 floppy; the sd1 does not show the demo disks.Arguably this is not quite right because all the demos would at least technically work even on the 21-voice SD-1, in particular those for other keyboards (SQ and KS series) which only use the SD-1's sequencer; but any SD-1/32 demos would run out of voices and thus sound worse than they should if played on an SD-1 (21-voice), so it seems a safer bet to make those only available on the SD-1/32.
(Edited to add:)
This PR also adds the text printed on the labels of the floppies as
<notes>. I sadly don't have a physical SD-1 Sequencer OS 3.00 floppy so I was not able to include the print from that label, but I expect it would have been very similar to what's on the SD-1 Sequencer OS 4.00 and 4.10 floppies.