-
Notifications
You must be signed in to change notification settings - Fork 2.3k
skeleton/digijet.cpp: Add new NOT WORKING clone #14685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stonedDiscord
wants to merge
19
commits into
mamedev:master
Choose a base branch
from
stonedDiscord:digijet2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+249
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
ajrhacker
reviewed
Dec 18, 2025
| uint8_t digijet_state::read_adc(offs_t offset) | ||
| { | ||
| return m_io_adc[offset & 0x03]->read(); //FIXME this is a hack | ||
| // The address lines connected to the ADC are A8-A11 but those can't be accessed externally by this CPU |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P20-P23 outputs are time-multiplexed with A8-A11 on MCS-48 parts executing from external memory.
I thought that the ADC hookup might use the PROG expander protocol, but from other comments that doesn't sound like the case here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Volkswagen Digijet (1990) [stonedDiscord]