Skip to content

Feat/socialink optional #139 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

koreanddinghwan
Copy link
Contributor

1. update시 social link없으면 프로필 hide하는 라인 삭제
2. activation시 sociallink 검증 삭제
@koreanddinghwan
Copy link
Contributor Author

origin에서 upstream/develop 동기화 안하고해서 그거 맞추고 다시 날렸습니당

@koreanddinghwan koreanddinghwan added the feature feature label Oct 11, 2023
Copy link
Member

@JuneParkCode JuneParkCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 천천히 처리하려고 했던건데... 깜짝 놀랐읍니다...

@koreanddinghwan koreanddinghwan merged commit 7a1f079 into manito42:develop Oct 11, 2023
@koreanddinghwan koreanddinghwan deleted the feat/socialink_optional branch October 11, 2023 02:07
koreanddinghwan added a commit to koreanddinghwan/manito42 that referenced this pull request Oct 13, 2023
manito42#141 에서 socialLink null로 받을 때 '' 빈 문자열로 바꾸는 코드가 생략되는 문제 발생.
koreanddinghwan added a commit that referenced this pull request Oct 13, 2023
#141 에서 socialLink null로 받을 때 '' 빈 문자열로 바꾸는 코드가 생략되는 문제 발생.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants