-
Notifications
You must be signed in to change notification settings - Fork 27
Add dynamicUpdate method #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drboyer
wants to merge
3
commits into
master
Choose a base branch
from
dynamic-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| .nyc_output | ||
| .nyc_output/ | ||
| coverage/ | ||
| node_modules/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| var _ = require('underscore'); | ||
|
|
||
| module.exports = function(client) { | ||
| var updates = {}; | ||
|
|
||
| updates.dynamicUpdate = function (newObject, updateParams, callback) { | ||
| var expressionObject = { | ||
| ExpressionAttributeNames: {}, | ||
| ExpressionAttributeValues: {} | ||
| }; | ||
| var updateExpressionParts = []; | ||
|
|
||
| Object.keys(newObject).forEach(function (key) { | ||
| if (Object.keys(updateParams.Key).indexOf(key) !== -1) return; | ||
|
|
||
| expressionObject.ExpressionAttributeNames['#' + key] = key; | ||
| expressionObject.ExpressionAttributeValues[':' + key] = newObject[key]; | ||
| updateExpressionParts.push('#' + key + ' = :' + key); | ||
| }); | ||
| expressionObject.UpdateExpression = 'set ' + updateExpressionParts.join(', '); | ||
|
|
||
| updateParams = _.extend(updateParams, expressionObject); | ||
| return client.update(updateParams, callback); | ||
| }; | ||
|
|
||
| return updates; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| var test = require('tape'); | ||
| var testTables = require('./test-tables'); | ||
| var dynamodb = require('dynamodb-test')(test, 'dyno', testTables.idhash); | ||
| var Dyno = require('..'); | ||
| var Update = require('../lib/update'); | ||
| var _ = require('underscore'); | ||
|
|
||
| var fixtures = _.range(10).map(function (i) { | ||
| return { | ||
| id: i.toString(), | ||
| idPower2: Math.pow(i, 2), | ||
| text: 'string' | ||
| }; | ||
| }); | ||
|
|
||
| test('[update] properties', function (assert) { | ||
| var update = Update(dynamodb.dynamodb); | ||
| assert.equal(typeof update.dynamicUpdate, 'function', 'exposes dynamicUpdate function'); | ||
| assert.end(); | ||
| }); | ||
|
|
||
| dynamodb.start(); | ||
|
|
||
| dynamodb.test('[update] dynamicUpdate - update all fields', fixtures, function (assert) { | ||
| var dyno = Dyno({ | ||
| table: dynamodb.tableName, | ||
| region: 'local', | ||
| endpoint: 'http://localhost:4567' | ||
| }); | ||
|
|
||
| var newObject = { | ||
| id: '2', | ||
| idPower2: -99, | ||
| text: 'update string' | ||
| }; | ||
| var updateParams = { | ||
| TableName: dynamodb.tableName, | ||
| Key: { id: '2' }, | ||
| ReturnValues: 'ALL_NEW' | ||
| }; | ||
|
|
||
| dyno.dynamicUpdate(newObject, updateParams, function (err, response) { | ||
| assert.ifError(err, 'dynamicUpdate errored'); | ||
| assert.deepEqual(response, { Attributes: { id: '2', idPower2: -99, text: 'update string' } }, 'expected new values'); | ||
| assert.end(); | ||
| }); | ||
| }); | ||
|
|
||
| dynamodb.test('[update] dynamicUpdate - only add new field', fixtures, function (assert) { | ||
| var dyno = Dyno({ | ||
| table: dynamodb.tableName, | ||
| region: 'local', | ||
| endpoint: 'http://localhost:4567' | ||
| }); | ||
|
|
||
| var newObject = { | ||
| id: '2', | ||
| newDateField: '2017-10-31' | ||
| }; | ||
| var updateParams = { | ||
| TableName: dynamodb.tableName, | ||
| Key: { id: '0' }, | ||
| ReturnValues: 'ALL_NEW' | ||
| }; | ||
|
|
||
| var expectedRow = { id: '0', idPower2: 0, newDateField: '2017-10-31', text: 'string' }; | ||
| dyno.dynamicUpdate(newObject, updateParams, function (err, response) { | ||
| assert.ifError(err, 'dynamicUpdate errored'); | ||
| assert.deepEqual(response, { Attributes: expectedRow }, 'expected new values'); | ||
| dyno.query({ KeyConditionExpression: 'id = :id', ExpressionAttributeValues: { ':id': '0' } }, function (err, queryResponse) { | ||
| assert.ifError(err, 'query error'); | ||
| assert.deepEqual(queryResponse.Items, [expectedRow], 'expected query response'); | ||
| assert.end(); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| dynamodb.delete(); | ||
| dynamodb.close(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I suggest we rename
keyto something else? Right now we're checking whetherkeyis in theupdateParams.Key's key list, it might be clearer if it was more explicit, i.e.newObjectKeyor similar.