CarPlay maneuver color fix #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype when generating maneuver arrow for carplay
Codecov Report
@@ Coverage Diff @@
## main #4482 +/- ##
==========================================
+ Coverage 58.30% 58.31% +0.01%
==========================================
Files 189 189
Lines 21196 21190 -6
==========================================
Hits 12358 12358
+ Misses 8838 8832 -6
|
kried
approved these changes
Jun 19, 2023
| @@ -919,9 +919,8 @@ open class CarPlayNavigationViewController: UIViewController, BuildingHighlighti | |||
|
|
|||
| // Add maneuver arrow | |||
| if #available(iOS 13.0, *) { | |||
| let userInterfaceStyle = traitCollection.userInterfaceStyle | |||
There was a problem hiding this comment.
I'm just wondering if we have any CarPlay screenshot tests.
There was a problem hiding this comment.
We have maneuver view snapshot test, but for CarPlay it is presented not like a view, but through the generated image, and that's why it was not updated as the rest of the views. Using image instead of a view is a CarPlay specifics
Udumft
added a commit
that referenced
this pull request
Jun 19, 2023
* vk/NAVIOS-1233-carplay-maneuver-color: fixed applying correct style type when generating maneuver arrow for carplay; CHANGELOG updated
Udumft
added a commit
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed applying correct style type when generating maneuver arrow for CarPlay by using the style type instead of interface idiom