feat: allow .tree cluster-data for higher-order networks#425
Draft
feat: allow .tree cluster-data for higher-order networks#425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.treeand.ftreecluster-data input to be normalized to state-level leaf ids before the existing tree init path runsWhy
Issue #247 asks for tree-based cluster-data input to work through the normal optimization flow. The previous implementation only matched tree leaves directly by state id, which meant physical tree input on higher-order networks was not handled safely through the public
--cluster-data/cluster_datainterfaces.Validation
make test-native CTEST_ARGS='-R partition'make build-native test-nativemake build-python test-python test-js-metadata test-docsusing the local venv toolchainmake test-sanitizers CTEST_ARGS='-R partition'Closes: #247