Fix excessive attribution control rerendering

[viernullvier]

The lead-up

In one of my projects I noticed a weird flickering on the attribution control that seemed to be related to rapid data updates. Notably, it only occurred in Firefox and not in Chromium, so I started to investigate.

The issue

Since attribution strings can include untrusted HTML, PR #5057 introduces a bit of input sanitization to mitigate potential XSS attacks trough the attribution field. The attribution control includes a mechanism to suppress excessive re-renders, but #5057 introduced a bug: The suppression logic compares the cached sanitized result with the new unsanitized result. This will lead to excessive DOM updates if the sanitized attribution actually differs from the unsanitized one, for instance if it contains a © HTML entity that gets transformed into a © literal.

The fix

This PR reverts some of the changes in #5057: The attribution control will cache the unsanitized input again instead of the sanitized result and only call the sanitizer directly when updating the DOM. This might even bring a minor performance improvement since the sanitizer will no longer be called on every update, but only if the unsanitized input has been changed.

Launch Checklist

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Include before/after visuals or gifs if this PR includes visual changes.
• Write tests for all new functionality.
• Document any changes to public APIs.
• Post benchmark scores.
• Add an entry to CHANGELOG.md under the ## main section.

[HarelM]

Thanks!
Ping me when this is ready for review as I don't get notified when a PR status is changed from drag to ready for review.

[viernullvier]

@HarelM I think it's ready for review if you don't mind the lack of benchmarks - the headless benchmarks keep crashing on my machine and the in-browser ones are causing out-of-memory issues.

[HarelM]

Benchmark results for the attribution control is not interesting.

[HarelM]

LGTM THANKS!