Skip to content

feat: Clarify error message language so if layout and paint properties are confused in setPaintProperty or setLayoutProperty - #7381

Merged
CommanderStorm merged 7 commits into
maplibre:mainfrom
CommanderStorm:Willjfield/main
Apr 3, 2026
Merged

feat: Clarify error message language so if layout and paint properties are confused in setPaintProperty or setLayoutProperty#7381
CommanderStorm merged 7 commits into
maplibre:mainfrom
CommanderStorm:Willjfield/main

Conversation

@CommanderStorm

Copy link
Copy Markdown
Member
  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!

This PR Fixes the code review issues that were discovered in #6954

CommanderStorm and others added 2 commits April 3, 2026 01:23
Co-Authored-By: Will Field <wfield@gc.cuny.edu>
Co-Authored-By: Will Field <wjf247@nyu.edu>
@codecov

codecov Bot commented Apr 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.57%. Comparing base (7951eec) to head (33a57fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7381      +/-   ##
==========================================
- Coverage   92.84%   92.57%   -0.28%     
==========================================
  Files         288      288              
  Lines       24012    24027      +15     
  Branches     5099     5103       +4     
==========================================
- Hits        22294    22243      -51     
- Misses       1718     1784      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/style/style_layer.ts Outdated
@HarelM

HarelM commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

@CommanderStorm can you check the coverage report to see if more tests are needed?

@CommanderStorm
CommanderStorm enabled auto-merge (squash) April 3, 2026 09:04
@CommanderStorm
CommanderStorm merged commit fb151e4 into maplibre:main Apr 3, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants