Skip to content

feat: global-state support for sky.*#7967

Merged
CommanderStorm merged 9 commits into
maplibre:mainfrom
CommanderStorm:sky-global-state
Jul 23, 2026
Merged

feat: global-state support for sky.*#7967
CommanderStorm merged 9 commits into
maplibre:mainfrom
CommanderStorm:sky-global-state

Conversation

@CommanderStorm

Copy link
Copy Markdown
Member

Adds global state support for sky.*

As with previous runs, more tests for all of the interesting cases.
Renderer code is not a big deal imo, just plumbing.

This needs different scenes, because:

  • fog only shows with terrain, not globe
  • atmosphere only shows in globe
  • sky in both

So a minimal testcase for each is a bit different, which is fine.

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.36%. Comparing base (7dfd543) to head (b66332d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7967      +/-   ##
==========================================
- Coverage   93.37%   93.36%   -0.01%     
==========================================
  Files         288      288              
  Lines       24446    24446              
  Branches     6461     6461              
==========================================
- Hits        22827    22825       -2     
- Misses       1619     1621       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/integration/render/tests/sky/atmosphere-blend/global-state/style.json Outdated
Comment thread test/integration/render/tests/sky/fog-color/global-state/style.json Outdated
@HarelM

HarelM commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

I'll let you go over the other tests and see if you can remove calling methods on map object as part of the render tests.
The code change is straight forward.
We need to remember that render tests takes time to run and should be treated as e2e tests and not cover every possible code flow. For that we have unit tests.

CommanderStorm and others added 5 commits July 23, 2026 15:26
Removes `setGlobalStateProperty` operations and sets the desired test
values as defaults directly, matching the pattern used by all other
global-state render tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All sky.* and light.* global-state render tests now follow the same
pattern as every other global-state render test: desired value set
directly as the state default, no operations needed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sky/roll/roll-0, roll10 and roll180 expected.png files were regenerated
instead of just being moved from the old sky/basic and sky/roll10/roll180
locations. Restore them to the original content so git detects them as
renames.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@CommanderStorm
CommanderStorm enabled auto-merge (squash) July 23, 2026 13:58
@CommanderStorm
CommanderStorm requested a review from HarelM July 23, 2026 13:59
@CommanderStorm
CommanderStorm merged commit ad2fcdb into maplibre:main Jul 23, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants