feat: global-state support for sky.*#7967
Merged
Merged
Conversation
CommanderStorm
force-pushed
the
sky-global-state
branch
from
July 19, 2026 15:36
1639071 to
fae8662
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7967 +/- ##
==========================================
- Coverage 93.37% 93.36% -0.01%
==========================================
Files 288 288
Lines 24446 24446
Branches 6461 6461
==========================================
- Hits 22827 22825 -2
- Misses 1619 1621 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HarelM
reviewed
Jul 23, 2026
HarelM
reviewed
Jul 23, 2026
Collaborator
|
I'll let you go over the other tests and see if you can remove calling methods on map object as part of the render tests. |
Removes `setGlobalStateProperty` operations and sets the desired test values as defaults directly, matching the pattern used by all other global-state render tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All sky.* and light.* global-state render tests now follow the same pattern as every other global-state render test: desired value set directly as the state default, no operations needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sky/roll/roll-0, roll10 and roll180 expected.png files were regenerated instead of just being moved from the old sky/basic and sky/roll10/roll180 locations. Restore them to the original content so git detects them as renames. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CommanderStorm
enabled auto-merge (squash)
July 23, 2026 13:58
HarelM
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds global state support for
sky.*As with previous runs, more tests for all of the interesting cases.
Renderer code is not a big deal imo, just plumbing.
This needs different scenes, because:
So a minimal testcase for each is a bit different, which is fine.