Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update framework to ignore most formatting differences between #542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhou1
Copy link
Contributor

@rhou1 rhou1 commented Feb 11, 2019

Apache JDBC and Simba JDBC results.
Added ability to include Jira number to failed tests.

Apache JDBC and Simba JDBC results.
Added ability to include Jira number to failed tests.
@@ -101,14 +128,17 @@ public String toString() {
int type = (Integer) (types.get(i));
if (Simba && (type == Types.VARCHAR)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should ideally be set as isSimba

if ((s1.length() > 0) &&
((s1.charAt(0) == '{') || (s1.charAt(0) == '[')) ) {
s1 = Utils.removeNewLines(s1);
s1 = removeStringSpace(s1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be libraries that do the reverse of prettifying JSON string, including stripping down extra spaces. Consider having a single Util method that does something like s1 = Utils.compactJson(s1);

if (FOUNDFAILED) {
return null;
} else {
return Filename;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variables need to be in lower camel case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants