Set up Storybook for the ui/ design system, with branding, design tokens, and accessibility fixes - #2924
Open
ryanscherler wants to merge 2 commits into
Open
Set up Storybook for the ui/ design system, with branding, design tokens, and accessibility fixes#2924ryanscherler wants to merge 2 commits into
ryanscherler wants to merge 2 commits into
Conversation
Stories for all 43 primitives in src/components/ui, grouped sidebar, dark mode, and MapRoulette branding. Colors and fonts come from a single DTCG token file compiled with Style Dictionary, shared between Tailwind and Storybook's own theme so they don't drift apart. Wired up the a11y test addon, which turned up a handful of real, pre-existing bugs: missing accessible names on Progress/Popover, a couple of invalid ARIA roles (SidePanel, Item), and several color-contrast failures (Button's semantic variants, error text in Field/Form, muted zinc-500 text on tinted backgrounds). Fixed those too, including a dark-mode error-text color that was basically invisible (dark red on near-black). Also fixes the mobile header - the search bar was getting squeezed to about 16px wide below 768px - and a few dashboard widget style tweaks.
ryanscherler
force-pushed
the
feature/storybook
branch
from
September 23, 2026 19:41
0b8cc79 to
7c968d8
Compare
npm ci doesn't download Playwright's browser binaries, so the Storybook Vitest project (needs a real Chromium to mount stories) was failing to launch in CI even though all the actual tests passed. Same fix already used in e2e.yml.
Contributor
Author
|
@CollinBeczak heads up - the e2e failure here isn't from this PR. Same 6 tests (task-bundling, task-feature-collection x3, task-status, task-workflow) fail the same way - "Fixed"/"Not an Issue" button never appears - on unrelated PRs too, e.g. team-owner-role-v4 from last week: https://github.com/maproulette/maproulette-frontend/actions/runs/35140012460 Looks like a pre-existing flaky/broken bit of the e2e suite on v4, not something this PR introduced. Build (the check that was actually failing here) is green after adding the Playwright browser install step to build.yml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up Storybook for the ui/ component library - stories for all 43 primitives, MapRoulette branding, and a design-token file (colors + font) shared between Tailwind and Storybook's theme so they stay in sync.
Running the new a11y test addon against everything turned up some real, pre-existing bugs, not just Storybook issues: missing accessible names on Progress/Popover, a couple of invalid ARIA roles, some color-contrast failures on button/alert/error-text colors, and a dark-mode error-text color that was basically invisible. Fixed those along the way.
Also includes a mobile header fix (the search bar was getting squeezed to ~16px wide below 768px) and a few dashboard widget styling tweaks.