Open
Conversation
HowardvanRooijen
commented
Jun 6, 2025
HowardvanRooijen
commented
- Upgrade to .NET 8.0 LTS
- Replace Specflow with Reqnroll
- Update Microsoft.* Dependencies to 8.*
- Updated target framework from `net6.0` to `net8.0` for multiple projects. - Removed constructors from `InvalidEnrollmentConfigurationException` and `InvalidServiceManifestException` classes for simplification. - Updated `packages.lock.json` to reflect changes in dependencies, including upgrades to `Microsoft.Extensions` packages (versions `6.0.1` and `6.0.2`). - Removed `System.Memory` package, indicating a shift in memory management. - Updated several runtime dependencies related to security and cryptography to enhance performance and security. - Improved file handling and diagnostic capabilities with updates to `System.IO` and `System.Diagnostics` packages.
- Updated package references in multiple `.csproj` files, including `Endjin.RecommendedPractices.GitHub` to `2.1.18` and `Microsoft.Extensions.*` to version ranges starting with `8.0.*`. - Replaced `Corvus.Testing.SpecFlow` with `Corvus.Testing.ReqnRoll` across various source files and step definitions. - Changed configuration files from `specflow.json` to `reqnroll.json` to align with the new testing framework. - Updated `packages.lock.json` to reflect new dependencies and remove obsolete ones, ensuring compatibility with the updated packages.
This commit adds null-forgiving operators (`!`) to the calls of the `Get<T>()` method in `MarainServicesTenancyServiceCollectionExtensions.cs` and `CliServiceCollectionExtensions.cs`. This change asserts that the results of these calls will not be null, suppressing compiler warnings related to potential null reference exceptions.
Code Coverage Summary Report - Linux (No TFM)Summary
CoverageMarain.Services.Tenancy.Testing - 59.7%
Marain.TenantManagement.Abstractions - 86.9%
Marain.TenantManagement.Azure.BlobStorage - 87.8%
Marain.TenantManagement.Azure.Cosmos - 88.2%
Marain.TenantManagement.Azure.TableStorage - 87.8%
Marain.TenantManagement.Specs - 98.4%
|
Test Results97 tests 97 ✅ 1s ⏱️ Results for commit 1eb825f. ♻️ This comment has been updated with latest results. |
- Updated `Corvus` package references to version `4.0.0` in `Marain.TenantManagement.Abstractions`, `BlobStorage`, `Cosmos`, and `TableStorage` projects. - Removed reference to `Corvus.Identity.MicrosoftRest` in `Marain.TenantManagement.Cli`. - Simplified constructor in `UnenrollCommand.cs` by removing unnecessary parentheses. - Extensive updates to `packages.lock.json`, including dependency resolutions to newer versions like `Azure.Core` (1.46.1) and `Microsoft.Extensions.Caching.Memory` (8.0.1). - Removed `StyleCop.Analyzers` and `Roslynator.Analyzers`, indicating a shift in coding standards or analysis tools.
Updated `Marain.TenantManagement.Specs.csproj` to include the `<IsTestProject>true</IsTestProject>` property, indicating that this project is a test project.
…dotnet/Marain.TenantManagement into features/dotnet-8-update
…h stock testing task.
- Replaced `Newtonsoft.Json` with `System.Text.Json` in `TenantProviderContainerBindings.cs`. - Updated service collection configuration for JSON serialization. - Modified `LoadManifestFile` method to use `System.Text.Json` for deserialization.
…dotnet/Marain.TenantManagement into features/dotnet-8-update
Updated JSON serialization across the project to use System.Text.Json instead of Newtonsoft.Json. This includes changes to method signatures and variable types in `InMemoryTenantProvider.cs`, `TransientTenantManager.cs`, and CLI command files. Replaced `IJsonSerializerSettingsProvider` with `IJsonSerializerOptionsProvider` to align with the new serialization approach. Updated project dependencies to newer versions, including `Menes.Abstractions`, `Corvus.Tenancy.Abstractions`, and `Corvus.Storage`. Modified `TenantManagementServiceCollectionExtensions.cs` and `CliServiceCollectionExtensions.cs` to register new JSON serialization options and converters. Reflected changes in package versions and dependencies in `packages.lock.json`. Adjusted test specifications in `ManifestSteps.cs` and related files to ensure compatibility with the new JSON handling methods.
* Use record types (mutable list properties had been confusing System.Text.Json) * Configure polymorphic deserialization to enable successful deserialization of the abstract ServiceManifestRequiredConfigurationEntry records in the ServiceManifest * Replace various RegisterTransientContent calls with RegisterContent (the former expects you to be using DI, which we're not in these types, and which is also incompatible with constructor-based deserialization)
Updated the `Table` object instantiation to use C# 9.0 syntax. Consolidated parameters in the `AddRow` method for better readability.
Code Coverage Summary Report - Windows (No TFM)Summary
CoverageMarain.Services.Tenancy.Testing - 66.4%
Marain.TenantManagement.Abstractions - 86.3%
Marain.TenantManagement.Azure.BlobStorage - 84.6%
Marain.TenantManagement.Azure.Cosmos - 85%
Marain.TenantManagement.Azure.TableStorage - 84.2%
Marain.TenantManagement.Specs - 98.3%
|
Code Coverage Summary Report - Linux (No TFM)Summary
CoverageMarain.Services.Tenancy.Testing - 66.4%
Marain.TenantManagement.Abstractions - 86.3%
Marain.TenantManagement.Azure.BlobStorage - 84.6%
Marain.TenantManagement.Azure.Cosmos - 85%
Marain.TenantManagement.Azure.TableStorage - 84.2%
Marain.TenantManagement.Specs - 98.3%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.