refactor: chat_generation cleanup and bug fixes#78
Merged
Conversation
…on_images return type
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manage_conversation_imagesreturnedlen(int)for non-openai engines (TypeError waiting to happen) — corrected to return the count directlyBlobServiceClientimport (Azure import with no call site in this file)ENGINE_DEFAULTSandVALID_MODELSfrom inside the route handler to module-level constantsprintstatements from the route (request dumps, message history logs, chunk-by-chunk traces, tool call traces, base64 debug dumps)yieldblocks and apass-onlyif/else)app/clientfixture definitions fromtest_litellm_provider.py(now covered byconftest.py)Net: -206 lines, 0 behavior changes.
Test plan
141 passed, 1 warningbefore and after every commit