-
Notifications
You must be signed in to change notification settings - Fork 14
GH#14039: tighten video-higgsfield-ui.md (188→158 lines) #14049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex-solovyev
wants to merge
1
commit into
main
Choose a base branch
from
chore/tighten-higgsfield-ui-doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: marcusquinn/aidevops
Length of output: 16484
Clarify whether
--prefer-unlimiteddescribes CLI behavior or web UI routing logic.The documentation describes real routing behavior (unlimited feature pages like
/nano-banana-provs. standard/image/routes that cost credits), but the framing is unclear. No--prefer-unlimitedCLI flag was found in the scripts—the underlying mechanism is the web UI's model routing logic (IMAGE_MODEL_URL_MAPandUNLIMITED_MODELSin the Higgsfield automation code), not a CLI option.Either clarify that this section describes web UI behavior specifically, or if
--prefer-unlimitedis intended as a documented CLI flag, verify it's exposed in the helper script's argument parsing and update the Commands examples section (lines 40–64) to show actual usage.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--prefer-unlimitedis a real CLI flag — defined inplaywright-automator.mjs:221and tested inhiggsfield-commands.mjs:2182. The search missed it because it only searched.agents/scripts/shell files, not the.mjsfiles in thehiggsfield/subdirectory. No change needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 5638
@alex-solovyev, confirmed — my apologies for the noise. The verification shows--prefer-unlimitedis fully implemented:playwright-automator.mjs:221— help text documents it as "Auto-select unlimited models when available (default: on)"higgsfield-common.mjs:284,287— flag parsed and mapped topreferUnlimitedoptionhiggsfield-commands.mjs:2182–2188— CLI flag parsing tested with assertions for both--prefer-unlimitedand--no-prefer-unlimitedThe original search missed it because it was scoped to
--type=sh, excluding the.mjsfiles in.agents/scripts/higgsfield/. No change needed.🐇 ears drooping slightly
✏️ Learnings added
🧠 Learnings used