Open
Conversation
Owner
|
Hi, @nthsense The CI is failing, can you fix it, please? |
Contributor
Author
|
@marekdedic On it, thanks. I don't think this will fix the issues caused by marekdedic/prosemirror-unified#453, I believe those are separate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use TaskListItemExtension in my own project, I was getting RangeErrors from ProseMirror when creating the task list item and also when executing the Backspace handler. I believe these were due to differences in the structure of my document vs the structure that the TaskListItemExtension was expecting. The approach I am taking here uses built in methods of ProseMirror to calculate the start and end positions for replacement and will hopefully be resilient to more edge cases.
Additionally, I found that adding the Enter, Shift-Tab, and Tab behaviors make task lists a lot nicer to work with. I have included those changes in a separate commit however, so they can be applied separately.
I also would propose removing the Backspace behavior, since things seem to work in a more standard way if I take it out - however, I am simply fixing it for now.