fix: handle string representation for base in toString method

- Check if the argument is a string representation for the base. - Set base to 16 if the argument is "hex".
margelo · Aug 31, 2023 · fc1f41f · fc1f41f
1 parent 9e90739
commit fc1f41f
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/cpp/MGBigNumberHostObject.cpp b/cpp/MGBigNumberHostObject.cpp
@@ -333,9 +333,16 @@ namespace margelo
             std::shared_ptr<MGBigNumber> thiz = thisValue.getObject(runtime).getHostObject<MGBigNumber>(runtime);
 
             int base = 10;
-            if (!arguments[0].isUndefined() && arguments[0].isNumber())
-            {
-                base = (int)arguments[0].asNumber();
+            if (!arguments[0].isUndefined()) {
+                if (arguments[0].isNumber()) {
+                    base = (int)arguments[0].asNumber();
+                } else if (arguments[0].isString()) {
+                    std::string argValue = arguments[0].getString(runtime).utf8(runtime);
+                    if (argValue == "hex") {
+                        base = 16;
+                    }
+                    // TODO: Add more conditions here if you support other string representations for bases.
+                }
             }
             int len = -1;
             if (!arguments[1].isUndefined())