-
Notifications
You must be signed in to change notification settings - Fork 10
Addressing issue 89: incorporating SUP on App Registry as OCI Registry #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing issue 89: incorporating SUP on App Registry as OCI Registry #123
Conversation
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arne Broering <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
src/specification/application-package/resources/index.md.jinja2
Outdated
Show resolved
Hide resolved
system-design/specification/application-package/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/application-package/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/application-package/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/application-package/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/application-package/application-registry.md
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arne Broering <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
ajcraig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items I have found so far.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arne Broering <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
ajcraig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Silvanoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review. Pending files will follow.
Silvanoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another partial review.
In general I prefer the term "OCI registry" over "Container Image Registry" (or the extremely extended for space reasons, but incorrect "Container Registry")
Silvanoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3rd and before-last review
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing a previous broken code change suggestion.
system-design/specification/applications/application-registry.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
Signed-off-by: Arne Broering <[email protected]>
… content merged include the following two PRs: 1. margo/specification#124 2. margo/specification#123 Signed-off-by: Armand Craig <[email protected]>
Description
This PR implements the accepted SUP: App Registry as OCI Registry
Issues Addressed
Issue #89
Change Type
Please select the relevant options:
Checklist