Skip to content

Conversation

@plampix
Copy link

@plampix plampix commented Jul 7, 2016

We require watchdogs to change weight of the Galera servers, so they should have access to the fifo glbd creates.

@ayurchen ayurchen added this to the glb-1.1.0 milestone Jul 7, 2016
@ayurchen ayurchen self-assigned this Jul 7, 2016
#include <grp.h> // for getgrnam()

/* Change this to the user under which to run */
#define RUN_AS_USER "daemon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have RUN_AS_USER independently defined in two different files. This does not look good.

@ayurchen
Copy link
Contributor

ayurchen commented Jul 7, 2016

Hi Peter. Thanks for your pull request. Unfortunately it has some shortcomings which we would like you to address before we can accept it.

Also, lately we had to "formalize" accepting contributions from 3rd parties. To this end I have pushed contributor agreement files to the repo. Please pull and read the CONTRIBUTOR_AGREEMENT.txt and if you agree to it, sign the CONTRIBUTORS.txt file by putting your name and github login in it.

Finally it would be nice if you could rebase everything into a single commit.

Thanks,
Alex

@plampix
Copy link
Author

plampix commented Jul 21, 2016

Hi Alex,

The bash stuff wasn't supposed to be committed, now I know why I should use branches :)

I'll read the agreement and fix the stuff you mentioned.

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants