Skip to content

Commit

Permalink
Clarify the concurrency of OnDone with respect to the reactor, and ca…
Browse files Browse the repository at this point in the history
…ll out explicitly that outside use of the reactor might need holds in order for OnDone to be called concurrently.

PiperOrigin-RevId: 703460223
  • Loading branch information
tkoeppe authored and copybara-github committed Dec 6, 2024
1 parent b3a44f1 commit 32f5136
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions include/grpcpp/support/client_callback.h
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,10 @@ class ClientBidiReactor : public internal::ClientReactor {
/// all cases. If it is not called, it indicates an application-level problem
/// (like failure to remove a hold).
///
/// OnDone is called exactly once, and not concurrently with any (other)
/// reaction. (Holds may be needed (see above) to prevent OnDone from being
/// called concurrently with calls to the reactor from outside of reactions.)
///
/// \param[in] s The status outcome of this RPC
void OnDone(const grpc::Status& /*s*/) override {}

Expand Down

0 comments on commit 32f5136

Please sign in to comment.