Skip to content

Commit

Permalink
a bit more cleanup, and add a bunch of TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
markdroth committed Dec 12, 2024
1 parent 04359e1 commit 8370fae
Show file tree
Hide file tree
Showing 2 changed files with 82 additions and 114 deletions.
12 changes: 12 additions & 0 deletions test/cpp/end2end/xds/xds_end2end_test_lib.h
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,18 @@ class XdsEnd2endTest : public ::testing::TestWithParam<XdsTestType>,
class ServerThread {
public:
// A status notifier for xDS-enabled servers.
//
// TODO(yashykt): This notifier records the most recent state seen
// for every URI and then lets the caller wait until the status for
// that URI is the expected one. If we are expecting an update that
// has the same status as the previous one, then we really have no
// way of knowing whether the second update has actually been sent.
// A better approach here would be to queue the updates received by
// the notifier and then have a method to get the next update from
// the queue, if any.
// Also, we should change the callers to check not just the status
// but also the corresponding error message, so that we can verify
// that we're emitting useful error messages for our users.
class XdsServingStatusNotifier
: public grpc::XdsServerServingStatusNotifierInterface {
public:
Expand Down
Loading

0 comments on commit 8370fae

Please sign in to comment.