Skip to content

MLE-22819 - Replicating the stack trace #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BillFarber
Copy link
Contributor

No description provided.

@BillFarber BillFarber requested review from Copilot, anu3990 and rjrudin July 7, 2025 19:11
@BillFarber BillFarber requested a review from stevebio as a code owner July 7, 2025 19:11
Copilot

This comment was marked as outdated.

@BillFarber BillFarber force-pushed the task/replicateFormatBug branch 2 times, most recently from 97dc73c to 9a0e53a Compare July 7, 2025 19:20
@BillFarber BillFarber requested a review from Copilot July 7, 2025 19:20
@BillFarber BillFarber changed the title Replicating the stack trace MLE-22819 - Replicating the stack trace Jul 7, 2025
Copilot

This comment was marked as outdated.

@BillFarber BillFarber requested a review from Copilot July 7, 2025 19:25
@BillFarber BillFarber force-pushed the task/replicateFormatBug branch from 9a0e53a to 3b1a7f2 Compare July 7, 2025 19:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the existing document-read test to use try-with-resources, adds a disabled test to reproduce an empty-document behavior, and introduces a helper to write empty documents.

  • Refactors test() to use try-with-resources for both DatabaseClient and DocumentPage
  • Adds a new disabled test testEmptyDocWithNoExtension plus a helper method to write empty documents
  • Pulls in new imports required for generic document management and binary content handling
Comments suppressed due to low confidence (1)

marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadDocumentPageTest.java:61

  • [nitpick] The helper name suggests writing an empty document with a file extension, but it actually writes a URI without an extension. Consider renaming to something like writeEmptyDoc to match its behavior.
	protected void writeEmptyDocWithFileExtension(DatabaseClient client, String... collections) {

@BillFarber BillFarber force-pushed the task/replicateFormatBug branch 3 times, most recently from d877c2f to c37b432 Compare July 7, 2025 19:37
@BillFarber BillFarber force-pushed the task/replicateFormatBug branch from c37b432 to 1e59a0d Compare July 7, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant