-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-22819 - Replicating the stack trace #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
97dc73c
to
9a0e53a
Compare
9a0e53a
to
3b1a7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the existing document-read test to use try-with-resources, adds a disabled test to reproduce an empty-document behavior, and introduces a helper to write empty documents.
- Refactors
test()
to use try-with-resources for bothDatabaseClient
andDocumentPage
- Adds a new disabled test
testEmptyDocWithNoExtension
plus a helper method to write empty documents - Pulls in new imports required for generic document management and binary content handling
Comments suppressed due to low confidence (1)
marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadDocumentPageTest.java:61
- [nitpick] The helper name suggests writing an empty document with a file extension, but it actually writes a URI without an extension. Consider renaming to something like
writeEmptyDoc
to match its behavior.
protected void writeEmptyDocWithFileExtension(DatabaseClient client, String... collections) {
marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadDocumentPageTest.java
Show resolved
Hide resolved
marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadDocumentPageTest.java
Outdated
Show resolved
Hide resolved
marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadDocumentPageTest.java
Outdated
Show resolved
Hide resolved
d877c2f
to
c37b432
Compare
…ocument manager without an extension.
c37b432
to
1e59a0d
Compare
No description provided.