Skip to content

MLE-17505 Updated test for MarkLogic 12 #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jul 8, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 17:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the existing SSL test to reflect a change in MarkLogic 12’s behavior and adds a new version-specific test.

  • Refactored JUnit imports to explicit annotation imports.
  • Updated the noSslContext test’s assertion message to note ML 12 behavior.
  • Added noSslContextWithMarkLogic12 to expect an IO exception when connecting without SSL under ML 12.
Comments suppressed due to low confidence (1)

marklogic-client-api/src/test/java/com/marklogic/client/test/ssl/OneWaySSLTest.java:17

  • Assertion methods like assertThrows, assertEquals, and assertTrue are used without static imports. Please add import static org.junit.jupiter.api.Assertions.*; or qualify these calls with Assertions. to ensure the test compiles.
import org.junit.jupiter.api.Assertions;

@rjrudin rjrudin merged commit 6a9e64b into develop Jul 9, 2025
2 checks passed
@rjrudin rjrudin deleted the feature/17505-test-fix branch July 9, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants