Skip to content

MLE-12345 Going back to clearing the database #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

MLE-12345 Going back to clearing the database #1807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions ...pi-functionaltests/src/test/java/com/marklogic/client/functionaltest/ConnectedRESTQA.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.marklogic.client.impl.SSLUtil;
import com.marklogic.client.io.DocumentMetadataHandle;
import com.marklogic.client.io.DocumentMetadataHandle.Capability;
import com.marklogic.client.query.QueryManager;
import com.marklogic.mgmt.ManageClient;
import com.marklogic.mgmt.ManageConfig;
import com.marklogic.mgmt.resource.appservers.ServerManager;
Expand Down Expand Up @@ -313,21 +314,13 @@ public static void deleteDB(String dbName) {
}

public static void clearDB(int port) {
DatabaseClientBuilder builder = newDatabaseClientBuilder()
.withDigestAuth(admin_user, admin_password)
.withPort(port);

try (DatabaseClient client = builder.build()) {
// Trying an eval instead of a "DELETE v1/search", which leads to intermittent errors on Jenkins involving
// a "clear" operation on a forest failing.
String count = client.newServerEval()
.xquery("let $uris := " +
" for $uri in cts:uris((), (), cts:true-query()) " +
" let $_ := xdmp:document-delete($uri) " +
" return $uri " +
"return fn:count($uris)")
.evalAs(String.class);
LoggerFactory.getLogger(ConnectedRESTQA.class).info("Cleared database, deleting {} URIs", count);
try (DatabaseClient client = newDatabaseClientBuilder().withPort(port).build()) {
Copy link
Preview

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authentication configuration (admin_user and admin_password) that was present in the original implementation has been removed. This may cause authentication failures if the database requires explicit credentials.

Copilot uses AI. Check for mistakes.

QueryManager mgr = client.newQueryManager();
mgr.delete(mgr.newDeleteDefinition());
// Clearing the database occasionally causes a forest to not be available for a moment or two when the tests
// are running on Jenkins. This leads to intermittent failures. Waiting is not guaranteed to avoid the
// error but simply hopes to minimize the chance of an intermittent failure.
waitFor(2000);
Copy link
Preview

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic number 2000 should be extracted to a named constant to improve code readability and maintainability. Consider defining a constant like FOREST_AVAILABILITY_WAIT_MS.

Copilot uses AI. Check for mistakes.

}
}

Expand Down