Skip to content

Conversation

pengzhouml
Copy link
Collaborator

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 8, 2025 14:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configuring HAProxy at the group level within MarkLogic clusters, allowing different groups to have distinct HAProxy configurations that can override cluster-level settings.

  • Introduces group-level HAProxy configuration through a new HAProxyGroup type
  • Refactors HAProxy configuration generation to support both cluster and group-level settings
  • Updates CRD definitions to support the new group-level configuration schema

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/k8sutil/haProxyHelper.go Major refactoring of HAProxy configuration logic to support group-level overrides and merge configurations
pkg/k8sutil/haProxy.go Updates to pass context to configuration generation functions and fix typo in annotation key
config/crd/bases/marklogic.progress.com_marklogicclusters.yaml CRD schema updates to add HAProxyGroup configuration and targetPort field
api/v1/zz_generated.deepcopy.go Generated deepcopy methods for new HAProxyGroup type and pointer handling updates
api/v1/marklogiccluster_types.go Type change from HAProxy to HAProxyGroup for group-level configuration
api/v1/common_types.go New HAProxyGroup type definition and TcpPorts field changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@rwinieski rwinieski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash commits and wait for pipeline to be green before merging

@rwinieski rwinieski changed the title MLE-20430 Support Configure HAProxy At Group Level MLE-20430/Support Configure HAProxy At Group Level Oct 10, 2025
@pengzhouml pengzhouml merged commit 474511b into develop Oct 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants