MLE-24755 binary doc test fixes#1005
Conversation
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes two binary document test files by converting them from callback-based to async/await patterns and consolidating multiple test cases into single comprehensive tests.
Key Changes:
- Converted callback-based async code to modern async/await syntax
- Consolidated multiple separate test cases into single comprehensive test flows
- Changed from
removeAll()to targetedremove()for cleaner test isolation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test-complete/nodejs-documents-read-chunk.js | Modernized test to use async/await, consolidated write/read/verify/delete operations into a single test case |
| test-complete/nodejs-documents-binary-pdf.js | Converted to async/await pattern, merged separate test cases for write/read/metadata/delete into one comprehensive test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
left a comment
There was a problem hiding this comment.
LGTM. VS Code interestingly flags "should", "valcheck", and "q" as unused imports. The last 2 are correct - but removing "should" causes the test to fail. Bummer.
f4ea9f1 to
1d50e90
Compare
No description provided.