Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a hardcoded sleep timer with MarkLogic's mlWaitTillReady task for improved reliability when waiting for MarkLogic to be ready. The changes upgrade ml-gradle to version 6.2-SNAPSHOT to utilize this new task.
- Upgraded ml-gradle from version 5.0.0 to 6.2-SNAPSHOT
- Configured
mlWaitTillReadytask to wait for MarkLogic availability - Replaced 90-second sleep with
mlWaitTillReadytask invocation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-app/build.gradle | Upgraded ml-gradle to 6.2-SNAPSHOT and configured mlWaitTillReady task with default polling intervals |
| Jenkinsfile | Replaced hardcoded 90s sleep with mlWaitTillReady task execution before deployment steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
test-app/build.gradle
Outdated
| buildscript { | ||
| repositories { | ||
| mavenCentral() | ||
| // Needed for ml-gradle 6.2-SNAPSHOT mavenLocal() |
There was a problem hiding this comment.
Spacing and formatting issue: the comment has inconsistent whitespace with 'mavenLocal()' appearing on the same line instead of the next line.
| // Needed for ml-gradle 6.2-SNAPSHOT mavenLocal() | |
| // Needed for ml-gradle 6.2-SNAPSHOT | |
| mavenLocal() |
3fbcd15 to
e5a493b
Compare
e5a493b to
dc34ab8
Compare
No description provided.