Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates generated files with a new license header, adjusts existing plan-builder tests to align with changed vectorScore behavior, and adds an additional vectorScore test and a new Node server type.
- Updated license headers in generated JS files to Progress Software’s years.
- Modified expected values in
plan-builder-generated.jstests and introduced a fourthvectorScoretest. - Added a new
Nodeclass in the server type definitions.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-basic/plan-builder-generated.js | Bumped license, changed expected test assertions, and added a new vec.vectorScore#4 test without version guard. |
| lib/server-types-generated.js | Bumped license and inserted a newly generated Node class. |
Comments suppressed due to low confidence (1)
lib/server-types-generated.js:48
- [nitpick] The class name
Nodeis very generic and may collide with other common types (e.g., DOM Node). Consider using a more descriptive name to avoid ambiguity.
class Node extends ServerType {
| done(); | ||
| }).catch(done); | ||
| }); | ||
| it('vec.vectorScore#4', function(done) { |
There was a problem hiding this comment.
This new test isn’t guarded by the server version check used in the previous vectorScore tests, so it will run on versions <12 and likely fail. Consider adding if (serverConfiguration.serverVersion < 12) { this.skip(); } inside the test.
Suggested change
| it('vec.vectorScore#4', function(done) { | |
| it('vec.vectorScore#4', function(done) { | |
| if (serverConfiguration.serverVersion < 12) { | |
| this.skip(); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.