Closed
Conversation
… gulp global installation.
Should make it easier to write tests that test SSL with the Node Client.
… for node-client-api-ssl-server database.
…to changes in the server code.
… latest 12-nightly.
This commit includes fixes for - - Inflight Vulnerable to Denial-of-Service (DoS) via Memory Leak - 'brace-expansion' Package Vulnerable to Regular Expression Denial-of-Service (ReDoS) - GHSA-8cj5-5rvv-wf4v
Resolves dependabot alert - see marklogic#942
There was a problem hiding this comment.
Pull Request Overview
This pull request updates copyright headers across all test files from MarkLogic Corporation to Progress Software Corporation and extends the copyright year range to 2015-2025. Additionally, it includes minor test improvements including code structure fixes and new test cases.
- Update copyright headers from MarkLogic Corporation to Progress Software Corporation with 2015-2025 year range
- Fix minor code issues including bracket placement and assertion corrections
- Add new test files for vector utilities, SSL/TLS configuration, and shortest path functionality
Reviewed Changes
Copilot reviewed 298 out of 363 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test-complete/*.js | Updated copyright headers from MarkLogic to Progress Software |
| test-complete-proxy/*.js | Updated copyright headers from MarkLogic to Progress Software |
| test-basic/*.js | Updated copyright headers from MarkLogic to Progress Software |
| test-basic/vector-util-test.js | New test file for vector utility functions |
| test-basic/ssl-min-allow-tls-test.js | New test file for SSL/TLS minimum version testing |
| test-basic/shortest-path.js | New test file for shortest path functionality |
| test-basic/documents-read-xqy-docs.js | New test file for reading XQuery documents |
Comments suppressed due to low confidence (1)
test-complete/nodejs-documents-values.js:279
- The parentheses are incorrectly placed. The logical OR operation should be applied to the entire assertion, not just the string literals. The correct syntax should be:
(strData.should.containEql('"name":"covariance","_value":"0.35"')) || (strData.should.containEql('"name":"covariance","_value":"0.349999999999998"'));
strData.should.containEql(('"name":"covariance","_value":"0.35"') || ('"name":"covariance","_value":"0.349999999999998"'));
| }); | ||
|
|
||
| describe('tests for new scoring method - bm25', function() { | ||
| describe('tests for new scoring methods - bm25, random and zero using fromSearch.', function() { |
There was a problem hiding this comment.
[nitpick] The period at the end of the describe block title is inconsistent with other describe blocks and should be removed for consistency.
Suggested change
| describe('tests for new scoring methods - bm25, random and zero using fromSearch.', function() { | |
| describe('tests for new scoring methods - bm25, random and zero using fromSearch', function() { |
| }); | ||
|
|
||
| describe('tests for new scoring method - bm25', function() { | ||
| describe('tests for new scoring methods - bm25, random and zero using fromSearchDocs', function() { |
There was a problem hiding this comment.
[nitpick] Missing period at the end of the describe block title for consistency with the previous describe block.
Suggested change
| describe('tests for new scoring methods - bm25, random and zero using fromSearchDocs', function() { | |
| describe('tests for new scoring methods - bm25, random and zero using fromSearchDocs.', function() { |
| const testPlan = pbb.testPlan; | ||
|
|
||
| describe('tests for new vector fucntions.', function() { | ||
| describe('tests for new vector functions.', function() { |
There was a problem hiding this comment.
[nitpick] The period at the end of the describe block title is inconsistent with most other describe blocks and should be removed.
Suggested change
| describe('tests for new vector functions.', function() { | |
| describe('tests for new vector functions', function() { |
| const titleProp = dc('title'); | ||
| const execPlan = pbb.execPlan; | ||
|
|
||
| describe('tests for server-side shortest-path method.', function () { |
There was a problem hiding this comment.
[nitpick] The period at the end of the describe block title is inconsistent with most other describe blocks and should be removed.
Suggested change
| describe('tests for server-side shortest-path method.', function () { | |
| describe('tests for server-side shortest-path method', function () { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.