PDP-536: Adding copyright check#959
PDP-536: Adding copyright check#959SameeraPriyathamTadikonda merged 1 commit intomarklogic:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds copyright header validation to the existing PR workflow by integrating a reusable copyright check workflow and configuration.
- Renames the GitHub workflow from "JIRA ID Validator" to "PR Workflow" to reflect expanded functionality
- Adds a new copyright validation job that validates copyright headers in source files
- Introduces a copyright configuration file that excludes GitHub workflow files, documentation, and package files from copyright checks
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/pr-workflow.yaml | Renamed workflow and added copyright validation job using reusable workflow |
| .copyrightconfig | Added copyright validation configuration with exclusions for non-source files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # - Dotfiles already skipped automatically | ||
| # Enable by removing the leading '# ' from the next line and editing values. | ||
| # filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js | ||
| filesexcluded: .github/*, README.md, Jenkinsfile, package.json, package-lock.json No newline at end of file |
There was a problem hiding this comment.
[nitpick] The exclusion list includes .github/* which would exclude the workflow file itself, but the workflow file contains a copyright header validation job. Consider whether GitHub workflow files should be excluded from copyright validation or if they need copyright headers.
| filesexcluded: .github/*, README.md, Jenkinsfile, package.json, package-lock.json | |
| filesexcluded: README.md, Jenkinsfile, package.json, package-lock.json |
|
@SameeraPriyathamTadikonda Are we good to go ahead and merge this? |
2d8f70e
into
marklogic:develop
No description provided.