MLE-123456 - polaris fixes: remove unreachable break and continue sta…#967
Merged
stevebio merged 1 commit intomarklogic:developfrom Sep 22, 2025
Merged
Conversation
…tements, unused variables, and move return note_error line outside of the for loop, which was probably intended.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses static analysis issues identified by Polaris by cleaning up unreachable code and unused variables in the www-authenticate authentication library. The changes focus on improving code quality by removing dead code patterns.
- Removed unused variable declarations (
q,x,last_tok) - Eliminated unreachable
breakandcontinuestatements - Fixed placement of error return statement to execute after loop completion
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/www-authenticate-patched/www-authenticate.js | Removed unused variables and moved error return outside loop, eliminated unreachable break |
| lib/www-authenticate-patched/parsers.js | Removed unused variable and unreachable continue statement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
approved these changes
Sep 22, 2025
anu3990
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tements, unused variables, and move return note_error line outside of the for loop, which was probably intended.