Conversation
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
First batch of lint-oriented refactors introducing single quotes and preferring const/let over var. Key changes focus on:
- Replacing most var declarations with const/let and converting double quotes to single quotes.
- Updating ESLint rules to enforce no-var and prefer-const (plus related stylistic consistency).
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/www-authenticate-patched/www-authenticate.js | Converted var to const/let and single-quoted strings. |
| lib/www-authenticate-patched/user-credentials.js | Updated variable declarations and string quotes. |
| lib/www-authenticate-patched/parsers.js | Replaced var with let/const and added semicolons. |
| lib/www-authenticate-patched/md5.js | Switched var to const. |
| lib/values.js | Replaced var with const/let across function logic. |
| lib/values-builder.js | Modernized declarations (var → const/let). |
| lib/transforms.js | Updated variable declarations and style. |
| lib/transactions.js | Modernized declarations and spacing. |
| lib/server-exec.js | Replaced var with const/let and updated string style. |
| lib/rows.js | Updated import style and variable declarations. |
| lib/rest-server-properties.js | Updated declarations to const. |
| lib/responder.js | Large-scale var → const/let refactor and property access tweaks. |
| lib/resources-exec.js | Modernized declarations; adjusted error strings. |
| lib/resources-config.js | Updated declarations and error handling strings. |
| lib/requester.js | Refactored auth/request helpers to const/let. |
| lib/query-builder.js | Extensive var → const/let updates across builder utilities. |
| lib/proxy-generator.js | Adjusted error messages (template literals to plain strings). |
| lib/plan-builder.js | Minor string style update. |
| lib/plan-builder-base.js | Converted template literal without interpolation to plain string. |
| lib/patch-builder.js | Modernized internal builder helper declarations. |
| lib/optional.js | Updated variable declaration to const. |
| lib/operation.js | Modernized operation helper internals. |
| lib/mlutil.js | Refactored utility helpers to const/let. |
| lib/mllog.js | Updated util import to const. |
| lib/marklogic.js | Modernized module imports and declarations. |
| lib/internal.js | Normalized imports (single quotes) and const usage. |
| lib/graphs.js | Partial modernization (some var remain, duplicate import). |
| lib/extlibs.js | Updated declarations and maintained logic. |
| lib/endpointDeclarationValidator.js | Converted JSON schema quotes/style. |
| lib/endpoint-proxy.js | Minor error message & style updates. |
| lib/documents.js | Large-scale modernization of declarations. |
| lib/basic-loader.js | Simplified error messages (removed unused template literals). |
| eslint.config.js | Added no-var and prefer-const enforcement rules. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1523571 to
c8a9b1e
Compare
anu3990
left a comment
There was a problem hiding this comment.
Waiting for the second jenkins run to complete.
|
The tests failed again. Please check the following two - test-basic/endpoint-caller.js:84:35 and test-basic/service-caller.js:84:35 |
c8a9b1e to
f6e315f
Compare
|
Recent updates did not fix the test failures. Tests are still failing. |
f6e315f to
9b3ab77
Compare
|
Still getting 7 test failures when just replacing double quotes with single quotes, which makes no sense. Going to open a new PR. |
Just doing double quote replacement.