Allow sampling from uniform and categorical distributions#483
Open
balping wants to merge 2 commits intomarkrogoyski:developfrom
Open
Allow sampling from uniform and categorical distributions#483balping wants to merge 2 commits intomarkrogoyski:developfrom
balping wants to merge 2 commits intomarkrogoyski:developfrom
Conversation
Owner
|
Hi @balping, Thank you for your interest in MathPHP, and thank you for the PR to add random functions to the Uniform and Categorical distributions. The Uniform distribution random function looks good. For the Categorical distribution, how about first defining a simple public How does that sound? Thank you again for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can sample from uniform and categorical discrete distributions by calling
rand().Examples:
PS. I'm not sure why the static analysis is failing