Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin/docker-stats not working properly #1075 #1082

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

markshust
Copy link
Owner

No description provided.

Copy link

what-the-diff bot commented Mar 6, 2024

PR Summary

  • Modified Retrieval of Container IDs
    The method of gathering Container IDs within the compose/bin/docker-stats file was changed. This was achieved by using the read command as opposed to the previously used bin/docker-compose ps -q.

  • Improved Condition Checking for Container IDs
    Enhancements were made for the condition that verifies if there are no container IDs present. Rather than just checking if our collection is empty, we're now examining the actual length of the container IDs list. This promises a more detail-oriented check and hence reduces unexpected surprises.

  • Enhanced docker stats Command
    The command utilized for retrieving the statistics for Docker was updated to take multiple values instead of just one. It now includes all container IDs from the aforementioned list, which provides a more extensive and enriched view of your Docker stats.

@markshust markshust merged commit fb61e2d into master Mar 6, 2024
1 check passed
@markshust markshust deleted the feature/fix-docker-stats branch April 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant