Add ReferenceOneField component (continues #79) #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add filter and sort props to documentation - Sort props alphabetically in documentation - Copy Record Representation and Tips sections instead of referencing - Replace RecordField with TextField in documentation examples - Add label prop to ReferenceOneField in examples - Use SimpleShowLayout in InShowLayout story - Add loading prop to Loading story to make 'Loading...' message visible - Add test case for children prop - Sort referenceonefield alphabetically in astro.config.mjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work started by @MohnDoe in #79, which has been inactive for several months despite a thorough review by @slax57.
Changes
This PR implements the
ReferenceOneFieldcomponent and addresses all review feedback from #79:Original Implementation (by @MohnDoe)
ReferenceOneFieldcomponent implementationReview Feedback Addressed (this PR)
filterandsortprops to documentationTextFieldinstead ofRecordFieldwith properlabelpropsInShowLayoutstory to useSimpleShowLayoutas requestedloadingprop toLoadingstory to make the loading message visiblechildrenpropreferenceonefieldinastro.config.mjsCloses
Closes #78
Credit
Original implementation by @MohnDoe. This PR only addresses the review feedback to move the feature forward, as the original author has been unresponsive for several months.