Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the Raven REPL, enabling robust multi-line input by tracking delimiter balance and providing a better user experience. The main changes include a new
delimiter_depthutility, a refactored REPL input loop, and supporting code organization updates.REPL enhancements:
delimiter_depthfunction insrc/repl.rsto accurately count unclosed parentheses, braces, and brackets outside of strings and comments, supporting multi-line input in the REPL. Includes comprehensive unit tests.src/main.rsto use a newread_repl_snippetfunction, which reads user input until all delimiters are balanced, allowing for multi-line code entry. The prompt now changes to...>for continued input.ReplInputenum, providing clearer handling ofexit,quit,help, and code input.Code organization:
replmodule insrc/lib.rsto encapsulate REPL-related helpers.src/main.rsto use the newdelimiter_depthfunction from thereplmodule.Other:
Cargo.tomlfrom1.6.3to1.6.4to reflect these improvements.Closes #13