Skip to content

Feat: #1243 Add drag & drop functionality to nav items & replace right items with dropdown#1245

Open
frimpongopoku wants to merge 14 commits intomasterfrom
draggable-nav-custom-drag-fxnality
Open

Feat: #1243 Add drag & drop functionality to nav items & replace right items with dropdown#1245
frimpongopoku wants to merge 14 commits intomasterfrom
draggable-nav-custom-drag-fxnality

Conversation

@frimpongopoku
Copy link
Copy Markdown
Contributor

@frimpongopoku frimpongopoku commented Jul 25, 2024

Summary / Highlights

  • Admins can now reorder navigation menu items by dragging and dropping.
  • Interaction items on the right have now been moved to a dropdown.

Both the dragging, and the dropdown feature are hidden under feature flags. By default, communities will have the old arrows(move up and and down) on the left, with the add, edit and remove buttons on the right side of the nav items.

How to enable dragging for a community

Create a feature flag with name Draggable Navigation Items, and add your community.

How to enable dropdown feature for a community

Create a feature flag with name Dropdown View for Nav Items, and ad your community

DEMO

Screen.Recording.2024-07-24.at.11.24.03.mov

Details (Give details about what this PR accomplishes, include any screenshots etc.)

Testing Steps (Provide details on how your changes can be tested)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've tested my changes manually.
  • I've added unit tests to my PR.
Transparency (Project board)
  • I've given my PR a meaningful title.
  • I linked this PR to the relevant issue.
  • I moved the linked issue from the "Sprint backlog" to "In progress" when I started this.
  • I moved the linked issue to "QA Verification" now that it is ready to merge.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Performance improvement
  • Feature removal
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch or to a feature branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the
    issue number)
  • All tests are
    passing: Contributing Guidelines
  • New/updated tests are included

Other information: Any otherthing we need to know

@frimpongopoku frimpongopoku linked an issue Jul 25, 2024 that may be closed by this pull request
@frimpongopoku frimpongopoku changed the title Draggable-nav-custom-drag-fxnality Feat: #1243 Draggable-nav-custom-drag-fxnality Jul 25, 2024
@frimpongopoku frimpongopoku changed the title Feat: #1243 Draggable-nav-custom-drag-fxnality Feat: #1243 Add drag & drop functionality to nav items & replace right items with dropdown Jul 25, 2024
@abdullai-t abdullai-t changed the base branch from development-depracated-make-prs-to-master to master December 6, 2024 11:16
Copy link
Copy Markdown
Contributor

@abdullai-t abdullai-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅. Fix merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Custom Navigation Menu Items draggable

2 participants