Feat: #1243 Add drag & drop functionality to nav items & replace right items with dropdown#1245
Open
frimpongopoku wants to merge 14 commits intomasterfrom
Open
Feat: #1243 Add drag & drop functionality to nav items & replace right items with dropdown#1245frimpongopoku wants to merge 14 commits intomasterfrom
frimpongopoku wants to merge 14 commits intomasterfrom
Conversation
abdullai-t
approved these changes
Dec 6, 2024
Contributor
abdullai-t
left a comment
There was a problem hiding this comment.
LGTM ✅. Fix merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Highlights
Both the dragging, and the dropdown feature are hidden under feature flags. By default, communities will have the old arrows(move up and and down) on the left, with the add, edit and remove buttons on the right side of the nav items.
How to enable dragging for a community
Create a feature flag with name
Draggable Navigation Items, and add your community.How to enable dropdown feature for a community
Create a feature flag with name
Dropdown View for Nav Items, and ad your communityDEMO
Screen.Recording.2024-07-24.at.11.24.03.mov
Details (Give details about what this PR accomplishes, include any screenshots etc.)
Testing Steps (Provide details on how your changes can be tested)
Requirements
Transparency (Project board)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch or to a feature branch, not themainbranchfix #xxx[,#xxx], where "xxx" is theissue number)
passing: Contributing Guidelines
Other information: Any otherthing we need to know