Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tools + add upgrade workflow #3

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore: update tools + add upgrade workflow #3

merged 2 commits into from
Aug 6, 2024

Conversation

gberenice
Copy link
Member

@gberenice gberenice commented Aug 6, 2024 •
edited
Loading

This:

  • Updates template repo with the latest tools versions.
  • Adds a workflow to upgrade trunk weekly. MasterpointBot App is used to authenticate on behalf of the GitHub App installed on our repository due to some GITHUB_TOKEN limitations:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

See GitHub Actions' docs:

@gberenice gberenice requested review from Gowiem and oycyc August 6, 2024 16:00
Gowiem
Gowiem requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request -- Good stuff though Veronika!

.github/workflows/trunk-upgrade.yaml Outdated

on:
schedule:
# Every Monday @ 8am
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we'll be receiving these upgrade PRs across a bunch of different repos... let's turn down the cadence on this. I'm thinking we turn it down to once a month. Mind updating?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome btw 💯 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 Done.

Gowiem
Gowiem approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:!

@gberenice gberenice merged commit 9ab1e72 into main Aug 6, 2024
2 checks passed
@gberenice gberenice deleted the update-to-latest branch August 6, 2024 16:12
oycyc
oycyc reviewed Aug 6, 2024
View reviewed changes
.github/workflows/trunk-upgrade.yaml
Comment on lines +22 to +27
- name: Create Token for MasterpointBot App
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a #v2.1.0
id: generate-token
with:
app_id: ${{ secrets.MP_BOT_APP_ID }}
private_key: ${{ secrets.MP_BOT_APP_PRIVATE_KEY }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oycyc oycyc oycyc left review comments

@Gowiem Gowiem Gowiem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gberenice @Gowiem @oycyc