Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release-please): add release-please to default module configuration #4

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

gberenice
Copy link
Member

Info

Adds release-please work introduced by @Gowiem in masterpointio/terraform-aws-tailscale#25. We need this for each module in the Org.

@gberenice gberenice requested a review from Gowiem August 13, 2024 15:03
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did our first release for the tailscale module here: https://github.com/masterpointio/terraform-aws-tailscale/releases/tag/v1.3.0

I think I like it? It requires that we merge an extra PR, which is a bit overkill for single change releases... but it automates away some of the tedium and gives us a consistent system to utilize.

Any thoughts before we adopt this fully @gberenice @oycyc?

@oycyc
Copy link

oycyc commented Aug 14, 2024

Did our first release for the tailscale module here: https://github.com/masterpointio/terraform-aws-tailscale/releases/tag/v1.3.0

I think I like it? It requires that we merge an extra PR, which is a bit overkill for single change releases... but it automates away some of the tedium and gives us a consistent system to utilize.

Any thoughts before we adopt this fully @gberenice @oycyc?

I like it too, it's cleaner output and also even though we merge an extra PR, that step is substitutes us manually creating the release. a bit overkill for single change releases... if we don't want to create a release for something minor, I guess we can leave the PR open.

We can also use this flag to just create a release every time merge to the default branch, kind of like CloudPosse module does with their custom script. But I don't think it's too much extra work to merge that extra PR as an additional confirmation input from us.
image

@gberenice
Copy link
Member Author

We can also use this flag to just create a release every time merge to the default branch, kind of like CloudPosse module does with their custom script. But I don't think it's too much extra work to merge that extra PR as an additional confirmation input from us. image

@oycyc hm, I wish it was that simple, but it doesn't seem to work:(
release-please is designed around the PR-based workflow, and this parameter allows to handle some cases when a user needs to split PR creation from release tagging.

Look how they do a release without PR: https://github.com/googleapis/release-please-action/blob/7987652d64b4581673a76e33ad5e98e3dd56832f/.github/workflows/release-please.yaml#L37-L61

I think I like it? It requires that we merge an extra PR, which is a bit overkill for single change releases... but it automates away some of the tedium and gives us a consistent system to utilize.

@Gowiem I like the Cloudposse workflow more, but I'm fine with trying out the PR-based flow. If we find this approach tedious, we can add an auto-merge step (e.g. enable-pull-request-automerge) or tag creation without PR (as in the example above).

@Gowiem
Copy link
Member

Gowiem commented Aug 14, 2024

@gberenice yeah, I hear you on liking the CP way better. It may be that we build that out... for now since this is so simple + easy... let's go with this and see how we like it for a bit.

@gberenice gberenice merged commit bb62481 into main Aug 15, 2024
2 checks passed
@gberenice gberenice deleted the feature/add-release-please branch August 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants