Fixed Boolean logic for HCAPTCHA_SITE_KEY in _env.tpl#35
Open
pwhack wants to merge 4 commits intomastodon:mainfrom
Open
Fixed Boolean logic for HCAPTCHA_SITE_KEY in _env.tpl#35pwhack wants to merge 4 commits intomastodon:mainfrom
HCAPTCHA_SITE_KEY in _env.tpl#35pwhack wants to merge 4 commits intomastodon:mainfrom
Conversation
Contributor
|
Thank you for catching this! I'll approve once it starts passing the checks (you need to update the |
Author
|
Whoops, sorry about that, I should have thought about that. I've bumped the patch column of the version string. That appears to be what the test was looking for. Need anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Without this PR, someone specifying
mastodon.hcaptcha.enabled: falsein theirvalues.yamlfile will end up withHCAPTCHA_SITE_KEY:in theirmastodon-envandmastodon-env-predeployConfigMap objects. Tools like Argo CD won't be able to apply this null value and continually show the application as out of sync.I believe the intention in
_env.tplis for the user to be able to fully disable hcaptcha and not have lingering keys or values related to it. This PR fixes the intention by properly looking for a Boolean value rather than trying to cast it to a string object, with unclear behavior.