finaly I made it #6100
finaly I made it #6100
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code meets most of the requirements, there are a few critical issues that need to be addressed before we can approve the pull request. The href attributes are currently set to #, which means the links won't navigate anywhere. This is a significant issue as it affects the functionality of the navigation. Please update these to actual URLs or handle them with JavaScript if they are meant to be interactive. Additionally, ensure that the alt attribute for the logo image is more descriptive to enhance accessibility. Once these changes are made, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
The href attribute is set to #, which means the links will not navigate anywhere. Consider replacing # with actual URLs or using JavaScript to handle the click events if these are meant to be interactive elements.
src/index.html
Outdated
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#" |
There was a problem hiding this comment.
The href attribute is set to #, which means the links will not navigate anywhere. Consider replacing # with actual URLs or using JavaScript to handle the click events if these are meant to be interactive elements.
src/index.html
Outdated
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#" |
There was a problem hiding this comment.
The href attribute is set to #, which means the links will not navigate anywhere. Consider replacing # with actual URLs or using JavaScript to handle the click events if these are meant to be interactive elements.
src/index.html
Outdated
| <a | ||
| data-qa="hover" | ||
| class="nav__link" | ||
| href="#" |
There was a problem hiding this comment.
The href attribute is set to #, which means the links will not navigate anywhere. Consider replacing # with actual URLs or using JavaScript to handle the click events if these are meant to be interactive elements.
src/index.html
Outdated
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#" |
There was a problem hiding this comment.
The href attribute is set to #, which means the links will not navigate anywhere. Consider replacing # with actual URLs or using JavaScript to handle the click events if these are meant to be interactive elements.
src/index.html
Outdated
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#" |
There was a problem hiding this comment.
The href attribute is set to #, which means the links will not navigate anywhere. Consider replacing # with actual URLs or using JavaScript to handle the click events if these are meant to be interactive elements.
src/index.html
Outdated
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| data-qa="hover" |
There was a problem hiding this comment.
The data-qa attribute is used here, which might be intended for testing purposes. Ensure this attribute is necessary for your application, as it does not affect the visual rendering or functionality of the page.
src/style.css
Outdated
| /* display: flex; */ | ||
| /* stylelint-disable-next-line comment-empty-line-before */ | ||
| /* justify-content: center; */ |
There was a problem hiding this comment.
These CSS rules are commented out. If they are not needed, consider removing them to keep the code clean. If they are needed, uncomment them to apply the styles.
src/style.css
Outdated
| /* stylelint-disable font-family-name-quotes */ | ||
| /* stylelint-disable rule-empty-line-before */ |
There was a problem hiding this comment.
The stylelint directives are used to disable certain checks. Ensure that these are necessary, as they might hide potential issues in the code.
There was a problem hiding this comment.
Great job on addressing the issues from the previous review! 🎉 Your HTML and CSS files are well-structured, and you've effectively used semantic tags and CSS variables. While there were some initial concerns with the href attributes pointing to hash fragments and the alt attribute for the logo image, you've successfully updated these to meet the task requirements.
Remember, ensuring that IDs exist within the document or updating href attributes to actual URLs is crucial for functionality. Also, using descriptive alt text enhances accessibility, which is important for all users. Keep these best practices in mind as you continue to develop your skills. Well done, and keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a | ||
| href="#moyo-header" |
There was a problem hiding this comment.
The href attribute is set to #moyo-header, which means it will not navigate to any external page. Ensure that the ID moyo-header exists within the document or update the href to an actual URL.
| src="/src/images/logo.png" | ||
| alt="moyo-logo" |
There was a problem hiding this comment.
The alt attribute for the logo image is not descriptive enough. Consider using a more descriptive text to enhance accessibility, such as 'Moyo Company Logo'.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link is-active" | ||
| href="#apple" |
There was a problem hiding this comment.
The href attribute is set to #apple, which means it will not navigate to any external page. Ensure that the ID apple exists within the document or update the href to an actual URL.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#samsung" |
There was a problem hiding this comment.
The href attribute is set to #samsung, which means it will not navigate to any external page. Ensure that the ID samsung exists within the document or update the href to an actual URL.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#smartphones" |
There was a problem hiding this comment.
The href attribute is set to #smartphones, which means it will not navigate to any external page. Ensure that the ID smartphones exists within the document or update the href to an actual URL.
| > | ||
| <a | ||
| class="nav__link" | ||
| href="#laptops&computers" |
There was a problem hiding this comment.
The href attribute is set to #laptops&computers, which means it will not navigate to any external page. Ensure that the ID laptops&computers exists within the document or update the href to an actual URL.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#gadgets" |
There was a problem hiding this comment.
The href attribute is set to #gadgets, which means it will not navigate to any external page. Ensure that the ID gadgets exists within the document or update the href to an actual URL.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#tablets" |
There was a problem hiding this comment.
The href attribute is set to #tablets, which means it will not navigate to any external page. Ensure that the ID tablets exists within the document or update the href to an actual URL.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#photo" |
There was a problem hiding this comment.
The href attribute is set to #photo, which means it will not navigate to any external page. Ensure that the ID photo exists within the document or update the href to an actual URL.
| <li class="nav__item"> | ||
| <a | ||
| class="nav__link" | ||
| href="#video" |
There was a problem hiding this comment.
The href attribute is set to #video, which means it will not navigate to any external page. Ensure that the ID video exists within the document or update the href to an actual URL.
❗️ Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.