Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #6112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #6112

wants to merge 2 commits into from

Conversation

Oksanka-Bunchuk
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code meets most of the task requirements and constraints, and the HTML and CSS files are well-structured and organized. However, there are a few areas for improvement:

  1. Universal Selector: Avoid using the universal selector * to reset margins and paddings, as it can impact performance.
  2. CSS Variable for Blue Color: Define a CSS variable for the blue color instead of using the color value directly.
  3. Logo Image Path: Ensure the src attribute for the logo image is set to [src/images](src/images) as specified.
  4. HTML Formatting: Format meta tag attributes correctly, with long values or more than two attributes starting on a new line with a 2-space indentation.
  5. CSS Font Configuration: Follow the task description for Google Fonts configuration, selecting only the roman style, medium (500) weight, and normal width.
  6. Missing CSS Fallback Fonts: Include fallback fonts in the font-family property for proper rendering if the main font fails to load.

These issues should be addressed to fully meet the task requirements. The decision to approve is made to help you move forward with your learning. Please review the comments to improve your code. Remember, addressing these issues will help you avoid similar problems in the future. Keep up the good work and continue learning from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants