Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created MOYO header #6116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michael-aleph
Copy link

@michael-aleph michael-aleph commented Feb 11, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • Header height is set in 1 place (for the links)

  • Content is vertically centered (for any header height)

  • CSS is used to show all letters in Uppercase (don't type them in HTML)

  • Logo is an image wrapped with a link

  • CSS Variable is used for a blue color

  • Pseudo-element is used for a blue line below the active link

  • Code follows all the Code Style Rules ❗️

  • The Google Fonts Configuration follows requirements.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is almost there! 🎉 However, there are a couple of critical issues that need to be addressed before we can approve it. Firstly, the CSS file uses tag names for styling, which goes against the checklist requirement. Please update your selectors to avoid using tag names, except for html and body. Secondly, the logo in your HTML should be wrapped with a link as specified in the task description. Once these changes are made, your solution will be ready for approval. Keep up the great work! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great progress on your project! 🎉 You've successfully addressed several issues, such as wrapping the logo with a link in the HTML file. However, there are still some areas that need attention:

  1. CSS File:

    • The universal selector * is used to reset margins and paddings, which is against the checklist requirement. Consider using more specific selectors like classes or IDs.
    • While using tag names for styling is generally discouraged, using body is acceptable. Ensure other tag selectors are replaced with class or ID selectors.
  2. HTML File:

    • The logo is now correctly wrapped with a link. Ensure the href attribute points to a valid destination.
    • The alt attribute for images is currently set to alt="moyo logo", which is acceptable. Make sure it accurately describes the image content.

Your solution is approved to help you move forward with your learning journey. 🚀 Please review the comments and make the necessary improvements to enhance your code quality. Addressing these issues will be crucial for future projects. Keep up the great work and continue learning from your experiences! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,3 +1,74 @@
body {
* {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the universal selector * is against the checklist requirement to avoid using tag names for styling, except for html and body. Consider using class or ID selectors instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants