layout_moyo-header #6117
layout_moyo-header #6117
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 While there are a few minor improvements suggested, such as using a CSS variable for the blue color and ensuring best practices in your HTML and CSS, these do not critically impact the functionality of your code. Keep up the good work and consider the feedback for future projects to enhance your skills even further! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" | ||
| crossorigin="use-credentials" |
There was a problem hiding this comment.
The crossorigin attribute should be set to anonymous instead of use-credentials for preconnect links to improve performance and avoid unnecessary credential requests.
| <header class="header"> | ||
| <a | ||
| class="home__link" | ||
| href="#index.html" |
There was a problem hiding this comment.
The href attribute in the home link should not reference #index.html. Consider using a valid URL or anchor reference.
| @@ -1,3 +1,58 @@ | |||
| body { | |||
| margin: 0; | |||
| font-family: Roboto, serif; | |||
There was a problem hiding this comment.
Consider adding a fallback font to the font-family declaration, such as sans-serif, to ensure proper rendering if 'Roboto' is unavailable.
| font-family: Roboto, serif; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| line-height: 14px; |
There was a problem hiding this comment.
It's recommended to use relative units like em or rem for line-height to ensure better scalability across different devices and user settings.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️
The Google Fonts Configuration follows requirements.
