-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #6121
base: master
Are you sure you want to change the base?
add task solution #6121
Conversation
Remdigger
commented
Feb 13, 2025
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work! 😊 There are a few critical issues that need to be addressed before we can approve the Pull Request. The Google Fonts configuration does not meet the specified requirements, as it includes a range of weights instead of the required medium (500) weight. Additionally, the href
attribute in the HTML file needs to be corrected for valid HTML by encoding the ampersand. Please make these changes, and your code will be ready for approval! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/index.html
Outdated
href="https://fonts.gstatic.com" | ||
/> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font weight values in the Google Fonts URL are incorrect. The range should be specified with a comma for different styles, not with '..'. For example, use '0,100;1,100' instead of '0,100..900;1,100..900'.
src/index.html
Outdated
<li> | ||
<a | ||
data-qa="hover" | ||
href="#laptops&computers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute value contains an ampersand ('&') which should be encoded as &
to ensure valid HTML. Change href="#laptops&computers"
to href="#laptops&computers"
.
body { | ||
margin: 0; | ||
font-family: Roboto, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the 'Roboto' font is correctly linked in the HTML file. If the font is not loading properly, check the link in the HTML file to ensure it's correct.
/* display: block; | ||
padding: 10px 0; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commented-out styles for .logo
might be unnecessary if they are not intended for future use. Consider removing them to keep the CSS clean.
/* display: flex; | ||
text-align: center; | ||
height: 60px; | ||
line-height: 60px; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commented-out styles for li
might be unnecessary if they are not intended for future use. Consider removing them to keep the CSS clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission! 🎉 You've made good progress in addressing the previous issues, but there are still a couple of critical points to correct:
-
Google Fonts Configuration: The current configuration includes a range of weights from 100 to 900. The task requires selecting only the roman style, medium (500) weight, and normal width. Please adjust the
href
attribute to include onlywght@500
. -
HTML
href
Attribute: Ensure thehref
attribute in the HTML file is valid by encoding the ampersand (&
) as&
. This is crucial for maintaining valid HTML.
These changes are important for meeting the task requirements and ensuring the functionality of your code. While the decision is to APPROVE your submission to help you move forward with your learning, please review the comments and make the necessary improvements. Keep up the good work, and continue to learn from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Google Fonts link includes a range of weights (100..900), but the task requires only the medium (500) weight. Please adjust the href
attribute to include only wght@500
.
src/index.html
Outdated
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute contains an ampersand (&
) that should be encoded as &
for valid HTML. Please update the link accordingly.